Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 12543009: Use JavaFile instead of Dart File. (Closed)

Created:
7 years, 9 months ago by scheglov
Modified:
7 years, 9 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use JavaFile instead of Dart File. This fixes two failing tests (which we were have to comment out). Plus, it also looks better IMHO, isolates File in single class, removing additional top-level functions. R=pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19585

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -174 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_engine_io.dart View 2 chunks +2 lines, -1 line 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/resources/java_io.dart View 2 chunks +26 lines, -19 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/SyntaxTranslator.java View 2 chunks +8 lines, -6 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/processor/IOSemanticProcessor.java View 4 chunks +11 lines, -36 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart/src/com/google/dart/java2dart/util/JavaUtils.java View 3 chunks +14 lines, -0 lines 0 comments Download
M editor/util/plugins/com.google.dart.java2dart_test/src/com/google/dart/java2dart/processor/IOSemanticProcessorTest.java View 4 chunks +11 lines, -11 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/element.dart View 6 chunks +46 lines, -14 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/java_engine_io.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/java_io.dart View 2 chunks +26 lines, -19 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/sdk.dart View 16 chunks +33 lines, -33 lines 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/source_io.dart View 11 chunks +26 lines, -26 lines 0 comments Download
M pkg/analyzer-experimental/test/generated/element_test.dart View 2 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 9 months ago (2013-03-06 19:14:56 UTC) #1
pquitslund
LGTM!
7 years, 9 months ago (2013-03-06 19:18:08 UTC) #2
scheglov
7 years, 9 months ago (2013-03-06 22:16:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698