Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 12543004: Import packages outside oauth2 via ../../.../pkg/ . This allows packages (Closed)

Created:
7 years, 9 months ago by dgrove
Modified:
7 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Import packages outside oauth2 via ../../.../pkg/ . This allows packages to have their imports rewritten and uploaded to pub. Committed: https://code.google.com/p/dart/source/detail?r=19566

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -17 lines) Patch
M pkg/oauth2/lib/src/authorization_code_grant.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/lib/src/client.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/lib/src/credentials.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/lib/src/handle_access_token_response.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/oauth2/test/authorization_code_grant_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/oauth2/test/client_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/oauth2/test/credentials_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/oauth2/test/handle_access_token_response_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/oauth2/test/utils.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/oauth2/test/utils_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
dgrove
7 years, 9 months ago (2013-03-06 17:11:59 UTC) #1
Bob Nystrom
lgtm
7 years, 9 months ago (2013-03-06 17:13:21 UTC) #2
dgrove
7 years, 9 months ago (2013-03-06 17:17:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19566 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698