Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 12541020: Consolidating platform code into dart:html_common (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Consolidating platform code into dart:html_common Basically a number of our platform checks are only accessible from dart:html and not other libs. Moved Device class over to html_common and added more platform logic which was distributed elsewhere. Also fixing up Device to cache the platform checks. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1357 lines, -1495 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 72 chunks +418 lines, -501 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 65 chunks +406 lines, -489 lines 0 comments Download
A sdk/lib/html/html_common/device.dart View 1 chunk +112 lines, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common.dart View 1 chunk +1 line, -0 lines 0 comments Download
M sdk/lib/html/html_common/html_common_dart2js.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 2 chunks +4 lines, -4 lines 0 comments Download
D tools/dom/src/Device.dart View 1 chunk +0 lines, -37 lines 0 comments Download
M tools/dom/src/KeyCode.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/src/KeyboardEventController.dart View 6 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +0 lines, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_CSSStyleDeclaration.darttemplate View 51 chunks +387 lines, -422 lines 0 comments Download
M tools/dom/templates/html/impl/impl_DOMException.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 2 chunks +3 lines, -3 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Event.darttemplate View 1 chunk +0 lines, -12 lines 0 comments Download
M tools/dom/templates/html/impl/impl_RTCPeerConnection.darttemplate View 2 chunks +4 lines, -4 lines 0 comments Download
M tools/dom/templates/html/impl/impl_TouchEvent.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_WheelEvent.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-07 00:35:06 UTC) #1
sra1
lgtm
7 years, 9 months ago (2013-03-09 02:00:45 UTC) #2
blois
7 years, 9 months ago (2013-03-12 00:49:39 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19833 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698