Issue 125393002: Add comments to document parameters of Dart_NativeEntryResolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 125393002: Add comments to document parameters of Dart_NativeEntryResolver. (Closed)

Created:
6 years, 11 months ago by siva

Modified:
6 years, 11 months ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add comments to document parameters of Dart_NativeEntryResolver. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31505

Patch Set 4 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -0 lines)			Patch
	M	runtime/include/dart_api.h	View	1 2 3	1 chunk	+15 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

lgtm https://codereview.chromium.org/125393002/diff/70001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/125393002/diff/70001/runtime/include/dart_api.h#newcode2147 runtime/include/dart_api.h:2147: * Document return value as well.

6 years, 11 months ago (2014-01-06 21:22:19 UTC) #2

siva

https://codereview.chromium.org/125393002/diff/70001/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/125393002/diff/70001/runtime/include/dart_api.h#newcode2147 runtime/include/dart_api.h:2147: * On 2014/01/06 21:22:19, srdjan wrote: > Document return ...

6 years, 11 months ago (2014-01-06 21:27:01 UTC) #3

siva

6 years, 11 months ago (2014-01-06 21:30:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r31505 (presubmit successful).

Expand Messages | Collapse Messages

Issue 125393002: Add comments to document parameters of Dart_NativeEntryResolver. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Messages