Issue 1253803002: Clean up bogus codepath in ContextManager._computePackageUriResolver.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1253803002: Clean up bogus codepath in ContextManager._computePackageUriResolver. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
danrubel, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Clean up bogus codepath in ContextManager._computePackageUriResolver. This codepath was only exercised during unit tests and race conditions. The fact that it was executed during unit tests at all was due to a bug (see #23909). The behavior during race conditions was incorrect (it tried to set up package resolution using a folder that didn't exist). This CL fixes the race condition behavior and disables the affected tests. In a future CL I will fix the underlying bug that caused the unit tests to execute incorrectly, and re-enable the tests. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/391741a2de83c821c31905620d036ba3fa8bda36

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -55 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		2 chunks	+8 lines, -2 lines	0 comments	Download
	M	pkg/analysis_server/test/context_manager_test.dart	View		4 chunks	+57 lines, -53 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Paul Berry

5 years, 5 months ago (2015-07-24 13:39:27 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
391741a2de83c821c31905620d036ba3fa8bda36 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages