dart2js: represent dump-info explicitly, so we can easily create tools that process the data

dart2js: represent dump-info explicitly, so we can easily create tools that process the data

R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/3ec292772e6255af212619da15676b5113edc8c1

[Siggi Cherem (dart-lang), 2015-07-24 00:36:16]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-07-24 00:57:55]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2015-07-24 00:58:00]

Patchset #1 (id:40001) has been deleted

[Siggi Cherem (dart-lang), 2015-07-24 00:58:05]

Patchset #1 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2015-07-24 01:07:58]

sigmund@google.com changed reviewers:
+ johnniwinther@google.com

[Siggi Cherem (dart-lang), 2015-07-24 01:07:58]

This adds the types and their serialization toJson, but no parsing at this time.


I tried to keep the collecting algorithm the same and made no changes the format
at this time (however the ids are allocated differently, so the id of an element
will be different after this change).

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
pkg/compiler/lib/src/dump_info.dart:8: show HtmlEscape, JsonEncoder,
StringConversionSink, ChunkedConversionSink;
FYI - I ran all files in the CL through dartfmt 0.2.0-rc1, so formatting changes
come from there.

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/info/info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:128: 'elements': {
seems wasteful that this is indented so much by the formatter :(, I filed a bug:
https://github.com/dart-lang/dart_style/issues/390

[karlklose, 2015-07-24 07:08:22]

karlklose@google.com changed reviewers:
+ karlklose@google.com

[karlklose, 2015-07-24 07:08:22]

DBC: very nice.

When analyzing the code size of large applications, it is incredibly useful to
have the dependency data in a format that is 1. easy to diff and 2. easy to
query.

When I worked on size of generated code, I had a tool that dumped the relevant
information into a prolog database: https://codereview.chromium.org/1259553002/,
to help me find out why certain functions ended up in the output.

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/info/info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:305: List<DependencyInfo> uses = [];
Please add type arguments to literals (several places).

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:345: final String mask;
Preferably we would have an enum that describes explicitly, what the dependency
is.

[Johnni Winther, 2015-07-27 10:14:42]

lgtm

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
pkg/compiler/lib/src/dump_info.dart:217: var modifiers = new FunctionModifiers(
Type the locals (dart2js style!)

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
pkg/compiler/lib/src/dump_info.dart:453: var functionElements =
Type the locals...

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/info/info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:41: // TODO(sigmund): make final (currently
not final because we amend the name in
'name in of' -> 'name of'

[Siggi Cherem (dart-lang), 2015-07-27 20:10:59]

thanks for the pointer to the prolog extraction Karl, it will be super useful
for me to extract the call-graph information soon.

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
File pkg/compiler/lib/src/dump_info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
pkg/compiler/lib/src/dump_info.dart:217: var modifiers = new FunctionModifiers(
On 2015/07/27 10:14:42, Johnni Winther wrote:
> Type the locals (dart2js style!)

:) -- changed for now, but we should chat about it. I think for local variables
that have a new expression in the initializer, it's just too redundant (I even
think we shouldn't do it for locals that are initialized with an expression that
contains a static type that matches what the type annotation would say :-))

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/du...
pkg/compiler/lib/src/dump_info.dart:453: var functionElements =
On 2015/07/27 10:14:42, Johnni Winther wrote:
> Type the locals...

Done.

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
File pkg/compiler/lib/src/info/info.dart (right):

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:41: // TODO(sigmund): make final (currently
not final because we amend the name in
On 2015/07/27 10:14:42, Johnni Winther wrote:
> 'name in of' -> 'name of'

Done.

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:305: List<DependencyInfo> uses = [];
On 2015/07/24 07:08:22, karlklose wrote:
> Please add type arguments to literals (several places).

Done. We should chat more about this long term - it would be nice to write the
types only once in a line.

https://codereview.chromium.org/1253763004/diff/80001/pkg/compiler/lib/src/in...
pkg/compiler/lib/src/info/info.dart:345: final String mask;
On 2015/07/24 07:08:22, karlklose wrote:
> Preferably we would have an enum that describes explicitly, what the
dependency
> is.

good point. I added a TODO for now. I'm thinking that once we add the rest of
the call-graph information this might become more clear.

[Siggi Cherem (dart-lang), 2015-08-10 16:59:43]

Patchset #4 (id:140001) has been deleted

[Siggi Cherem (dart-lang), 2015-08-10 18:14:19]

after testing this on some larger apps, I noticed a couple small things that
needed fixing.

There were mainly minor things, so I'll submit for now. Diff patchset 3 & 4 to
see what's changed:
- a missing entry in the json
- a missing default value
- registering created infos earlier (important because of the way we recursively
process nested elements)
- getting rid of unused code/warnings to make all tests pass (I'll add them back
later, then I'll probably add some to the "unused_apis" test later on.

[Siggi Cherem (dart-lang), 2015-08-10 19:53:47]

Committed patchset #4 (id:160001) manually as
3ec292772e6255af212619da15676b5113edc8c1 (presubmit successful).