Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12537009: Rename XMatching to XWhere. (Closed)

Created:
7 years, 9 months ago by floitsch
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, srdjan, kasperl
Visibility:
Public.

Description

Rename XMatching to XWhere. For example firstMatching -> firstWhere. BUG= http://dartbug.com/8664 BUG= http://dartbug.com/8337 Committed: https://code.google.com/p/dart/source/detail?r=19880

Patch Set 1 #

Patch Set 2 : Merge and rebuild dom libraries. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1073 lines, -1073 lines) Patch
M pkg/args/lib/args.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/serialization/lib/src/serialization_rule.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/serialization/test/serialization_test.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.dart View 4 chunks +16 lines, -16 lines 0 comments Download
M runtime/lib/byte_array.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M runtime/lib/growable_array.dart View 2 chunks +11 lines, -11 lines 0 comments Download
M runtime/lib/typeddata.dart View 1 2 chunks +8 lines, -8 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M sdk/lib/_collection_dev/iterable.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M sdk/lib/_collection_dev/list.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 2 chunks +11 lines, -11 lines 0 comments Download
M sdk/lib/async/stream.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M sdk/lib/collection/collections.dart View 8 chunks +16 lines, -16 lines 0 comments Download
M sdk/lib/collection/hash_set.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/collection/linked_hash_set.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/collection/queue.dart View 1 6 chunks +9 lines, -9 lines 0 comments Download
M sdk/lib/core/collection.dart View 2 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/core/iterable.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 72 chunks +293 lines, -293 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 72 chunks +293 lines, -293 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 12 chunks +48 lines, -48 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 1 12 chunks +48 lines, -48 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 2 chunks +8 lines, -8 lines 0 comments Download
M tests/corelib/collection_removes_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
D tests/corelib/iterable_first_matching_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
A tests/corelib/iterable_first_where_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
D tests/corelib/iterable_last_matching_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download
A tests/corelib/iterable_last_where_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download
D tests/corelib/iterable_single_matching_test.dart View 1 chunk +0 lines, -33 lines 0 comments Download
A tests/corelib/iterable_single_where_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
M tests/corelib/list_map_test.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M tests/corelib/list_reversed_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/corelib/queue_test.dart View 1 2 chunks +5 lines, -5 lines 0 comments Download
M tests/html/streams_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/html/transferables_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 1 chunk +16 lines, -16 lines 0 comments Download
M tools/dom/src/CssClassSet.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/src/WrappedList.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 4 chunks +18 lines, -18 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 1 2 chunks +10 lines, -10 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 2 chunks +8 lines, -8 lines 0 comments Download
M tools/testing/dart/vendored_pkg/args/args.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/lib/metadata.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
floitsch
7 years, 9 months ago (2013-03-09 00:32:22 UTC) #1
Lasse Reichstein Nielsen
lgtm
7 years, 9 months ago (2013-03-12 11:56:10 UTC) #2
floitsch
7 years, 9 months ago (2013-03-12 17:34:05 UTC) #3
floitsch
7 years, 9 months ago (2013-03-12 17:35:17 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r19880 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698