Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1253443003: dart2js: Support const symbols in the startup emitter. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, herhut
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js: Support const symbols in the startup emitter. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/f6b142c5f4c10a0f225ad0c25a2aad4260f2e789

Patch Set 1 #

Patch Set 2 : Remove TODO. #

Total comments: 4

Patch Set 3 : Improve comment. #

Patch Set 4 : Update comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 3 chunks +15 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 2 3 1 chunk +11 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
floitsch
5 years, 5 months ago (2015-07-22 15:43:48 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart (right): https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart#newcode1131 pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1131: // Otherwise, it is only relevant for reflection. ...
5 years, 5 months ago (2015-07-23 18:09:50 UTC) #3
floitsch
https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart (right): https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart#newcode1131 pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1131: // Otherwise, it is only relevant for reflection. On ...
5 years, 4 months ago (2015-07-29 18:08:37 UTC) #4
Siggi Cherem (dart-lang)
https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart (right): https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart#newcode1131 pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1131: // Otherwise, it is only relevant for reflection. On ...
5 years, 4 months ago (2015-07-30 16:44:02 UTC) #5
floitsch
https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart (right): https://codereview.chromium.org/1253443003/diff/20001/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart#newcode1131 pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1131: // Otherwise, it is only relevant for reflection. On ...
5 years, 4 months ago (2015-08-03 15:56:07 UTC) #6
floitsch
5 years, 4 months ago (2015-08-03 15:56:39 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
f6b142c5f4c10a0f225ad0c25a2aad4260f2e789 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698