Issue 12534008: Fix co19 expectations for Set methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12534008: Fix co19 expectations for Set methods. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix co19 expectations for Set methods. Committed: https://code.google.com/p/dart/source/detail?r=19929

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -0 lines)			Patch
	M	tests/co19/co19-dart2js.status	View		1 chunk	+16 lines, -0 lines	1 comment	Download
	M	tests/co19/co19-runtime.status	View		1 chunk	+16 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Committed patchset #1 manually as r19929 (presubmit successful).

7 years, 9 months ago (2013-03-13 13:56:13 UTC) #2

floitsch

7 years, 9 months ago (2013-03-13 13:59:00 UTC) #3

Message was sent while issue was closed.

LGTM.

https://codereview.chromium.org/12534008/diff/1/tests/co19/co19-dart2js.status
File tests/co19/co19-dart2js.status (right):

https://codereview.chromium.org/12534008/diff/1/tests/co19/co19-dart2js.statu...
tests/co19/co19-dart2js.status:661: LibTest/core/Set/intersection_A03_t01: Pass
# issue 390
Don't keep "pass" lines.
It makes it harder for Peter to merge co19.

https://codereview.chromium.org/12534008/diff/1/tests/co19/co19-runtime.status
File tests/co19/co19-runtime.status (right):

https://codereview.chromium.org/12534008/diff/1/tests/co19/co19-runtime.statu...
tests/co19/co19-runtime.status:620: LibTest/core/Set/intersection_A03_t01: Pass
# issue 390
ditto.

Expand Messages | Collapse Messages