Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Issue 1253373002: VM: Hoist handle allocation out of loop when creating the object pool. (Closed)

Created:
5 years, 4 months ago by Florian Schneider
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

VM: Hoist handle allocation out of loop when creating the object pool. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/f8670e8f8415635e3f06e6eff43819ad4bb9e89e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M runtime/vm/assembler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
5 years, 4 months ago (2015-07-27 11:02:32 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-07-27 14:01:20 UTC) #3
Florian Schneider
5 years, 4 months ago (2015-07-28 08:23:39 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f8670e8f8415635e3f06e6eff43819ad4bb9e89e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698