Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(490)

Issue 1253333002: dart2js cps: Support async/await by rewriting the JavaScript AST. (Closed)

Created:
5 years, 4 months ago by karlklose
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Support async/await by rewriting the JavaScript AST. BUG= R=kmillikin@google.com Committed: https://github.com/dart-lang/sdk/commit/bafb8fb191bfd07346523fb8f88c8b71ca630364

Patch Set 1 : #

Patch Set 2 : Remove async from bailout message. #

Patch Set 3 : Add issue number to status file. #

Total comments: 2

Patch Set 4 : Rewrite to switch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+513 lines, -466 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 chunks +10 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 3 chunks +22 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +12 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 3 2 chunks +56 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 3 chunks +10 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +7 lines, -53 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 5 chunks +25 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +2 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 chunks +2 lines, -1 line 0 comments Download
M tests/compiler/dart2js_extra/dart2js_extra.status View 1 2 2 chunks +7 lines, -8 lines 0 comments Download
M tests/compiler/dart2js_native/dart2js_native.status View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 5 chunks +86 lines, -160 lines 0 comments Download
M tests/lib/lib.status View 1 1 chunk +218 lines, -219 lines 0 comments Download
M tests/standalone/standalone.status View 1 1 chunk +8 lines, -15 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
karlklose
5 years, 4 months ago (2015-08-07 07:41:09 UTC) #4
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/1253333002/diff/80001/pkg/compiler/lib/src/js_backend/backend.dart File pkg/compiler/lib/src/js_backend/backend.dart (right): https://codereview.chromium.org/1253333002/diff/80001/pkg/compiler/lib/src/js_backend/backend.dart#newcode2764 pkg/compiler/lib/src/js_backend/backend.dart:2764: else if (element.asyncMarker == AsyncMarker.ASYNC_STAR) { else if ...
5 years, 4 months ago (2015-08-07 08:52:33 UTC) #5
karlklose
5 years, 4 months ago (2015-08-07 09:27:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:100001) manually as
bafb8fb191bfd07346523fb8f88c8b71ca630364 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698