Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 1253103007: WEB-17598. Name new libraries according to the Dart Style Guide. (Closed)

Created:
5 years, 4 months ago by scheglov
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -24 lines) Patch
M pkg/analysis_server/lib/edit/fix/fix_core.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/edit/fix/fix_dart.dart View 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/analysis_server/lib/src/edit/edit_domain.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix.dart View 7 chunks +19 lines, -10 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 8 chunks +54 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/services/correction/fix_test.dart View 2 chunks +43 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 4 months ago (2015-08-04 21:29:14 UTC) #1
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-04 21:41:12 UTC) #2
scheglov
5 years, 4 months ago (2015-08-04 21:47:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fbb7aedee54770c1c8a040aa9415cbd33a021785 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698