Issue 12531009: Fix typo in method calls for [] and []= operators in views.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12531009: Fix typo in method calls for [] and []= operators in views. (Closed)

Created:
7 years, 9 months ago by siva

Modified:
7 years, 9 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix typo in method calls for [] and []= operators in views. Committed: https://code.google.com/p/dart/source/detail?r=20033

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -43 lines)			Patch
M	runtime/lib/typeddata.dart	View		22 chunks	+43 lines, -43 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/standalone/typed_data_view_test.dart	View		1 chunk	+35 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

Florian Schneider

LGTM. Not sure if the test runs on dart2js? Should probably be skipped there.

7 years, 9 months ago (2013-03-14 14:52:31 UTC) #2

siva

7 years, 9 months ago (2013-03-14 16:47:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r20033 (presubmit successful).