Issue 12528008: Implement CHA through type mask and TypedSelector in the simple type inferrer.

Issue 12528008: Implement CHA through type mask and TypedSelector in the simple type inferrer. (Closed)

Created:
7 years, 9 months ago by ngeoffray

Modified:
7 years, 9 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement CHA through type mask and TypedSelector in the simple type inferrer. Committed: https://code.google.com/p/dart/source/detail?r=19689

Patch Set 6 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+250 lines, -160 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/compiler.dart	View	1	5 chunks	+14 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	5 chunks	+23 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+3 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1	2 chunks	+6 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types_propagation.dart	View	1	1 chunk	+1 line, -17 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/concrete_types_inferrer.dart	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart	View	1 2	16 chunks	+120 lines, -82 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/types/types.dart	View	1	5 chunks	+22 lines, -8 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/universe/universe.dart	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download
	tests/compiler/dart2js/concrete_type_inference_test.dart	View	1 2	2 chunks	+13 lines, -7 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/simple_inferrer_postfix_prefix_test.dart	View	1 2	3 chunks	+24 lines, -21 lines	0 comments	Download
M	tests/utils/dummy_compiler_test.dart	View	1 2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. https://codereview.chromium.org/12528008/diff/5001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart File sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart (right): https://codereview.chromium.org/12528008/diff/5001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1082 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1082: return inferrer.dynamicType; Use thisType? https://codereview.chromium.org/12528008/diff/5001/sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart#newcode1152 sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart:1152: // TODO(ngeoffray): ...

7 years, 9 months ago (2013-03-07 14:09:17 UTC) #2

ngeoffray

Thanks Kasper. PTAL. It turns out this CL revealed a couple of bugs in the ...

7 years, 9 months ago (2013-03-08 11:32:37 UTC) #3

kasperl

LGTM. https://codereview.chromium.org/12528008/diff/13001/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/12528008/diff/13001/sdk/lib/_internal/compiler/implementation/world.dart#newcode165 sdk/lib/_internal/compiler/implementation/world.dart:165: return subclasses[cls] != null && !subclasses[cls].isEmpty; Maybe avoid ...

7 years, 9 months ago (2013-03-08 11:39:30 UTC) #4

ngeoffray

Thanks Kasper. https://codereview.chromium.org/12528008/diff/13001/sdk/lib/_internal/compiler/implementation/world.dart File sdk/lib/_internal/compiler/implementation/world.dart (right): https://codereview.chromium.org/12528008/diff/13001/sdk/lib/_internal/compiler/implementation/world.dart#newcode165 sdk/lib/_internal/compiler/implementation/world.dart:165: return subclasses[cls] != null && !subclasses[cls].isEmpty; On ...

7 years, 9 months ago (2013-03-08 12:54:27 UTC) #5

ngeoffray

7 years, 9 months ago (2013-03-08 12:58:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 manually as r19689 (presubmit successful).

Expand Messages | Collapse Messages