Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 12528004: Check for canBePrimitiveNumber when doing the intersection on a number type. (Closed)

Created:
7 years, 9 months ago by ngeoffray
Modified:
7 years, 9 months ago
Reviewers:
kasperl
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Check for canBePrimitiveNumber when doing the intersection on a number type. Committed: https://code.google.com/p/dart/source/detail?r=19536

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/optimize.dart View 1 chunk +2 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/types.dart View 7 chunks +7 lines, -3 lines 0 comments Download
M tests/corelib/corelib.status View 1 chunk +0 lines, -3 lines 0 comments Download
A tests/language/type_intersection_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
Fixes https://code.google.com/p/dart/issues/detail?id=8904.
7 years, 9 months ago (2013-03-06 08:38:45 UTC) #1
kasperl
LGTM.
7 years, 9 months ago (2013-03-06 08:40:31 UTC) #2
ngeoffray
7 years, 9 months ago (2013-03-06 08:41:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19536 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698