A selector whose type mask is nullable, applies to methods on the null implementation.

A selector whose type mask is nullable, applies to methods on the null implementation.
Committed: https://code.google.com/p/dart/source/detail?r=19539

[karlklose, 2013-03-06 08:05:19]

DBC

https://codereview.chromium.org/12527006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12527006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:155: bool
isNullImplementation(ClassElement cls) {
Would it be better to call it the 'null class'?

https://codereview.chromium.org/12527006/diff/1/tests/language/null_method_te...
File tests/language/null_method_test.dart (right):

https://codereview.chromium.org/12527006/diff/1/tests/language/null_method_te...
tests/language/null_method_test.dart:17: Expect.isNotNull(0, c.foo(null));
Did you mean 'equals'?

[ngeoffray, 2013-03-06 08:08:25]

Thanks Karl.

https://codereview.chromium.org/12527006/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12527006/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/compiler.dart:155: bool
isNullImplementation(ClassElement cls) {
On 2013/03/06 08:05:20, karlklose wrote:
> Would it be better to call it the 'null class'?

No, the null class is the null class of the core library (or wherever it is
today).

https://codereview.chromium.org/12527006/diff/1/tests/language/null_method_te...
File tests/language/null_method_test.dart (right):

https://codereview.chromium.org/12527006/diff/1/tests/language/null_method_te...
tests/language/null_method_test.dart:17: Expect.isNotNull(0, c.foo(null));
On 2013/03/06 08:05:20, karlklose wrote:
> Did you mean 'equals'?

Good catch. The 0 is a leftover. Removed it.

[kasperl, 2013-03-06 08:32:26]

LGTM if you address Karl's comments.

https://codereview.chromium.org/12527006/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12527006/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:155: bool
isNullImplementation(ClassElement cls) {
Why do we need this on both the compiler and the backend? Is this actually used
from anywhere?

[ngeoffray, 2013-03-06 08:40:06]

https://codereview.chromium.org/12527006/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12527006/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:155: bool
isNullImplementation(ClassElement cls) {
On 2013/03/06 08:32:26, kasperl wrote:
> Why do we need this on both the compiler and the backend? Is this actually
used
> from anywhere?

This is the backend super class, not the compiler class :-)

[kasperl, 2013-03-06 08:41:07]

https://codereview.chromium.org/12527006/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/compiler.dart (right):

https://codereview.chromium.org/12527006/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/compiler.dart:155: bool
isNullImplementation(ClassElement cls) {
On 2013/03/06 08:40:06, ngeoffray wrote:
> On 2013/03/06 08:32:26, kasperl wrote:
> > Why do we need this on both the compiler and the backend? Is this actually
> used
> > from anywhere?
> 
> This is the backend super class, not the compiler class :-)

Ah. Funky.

[ngeoffray, 2013-03-06 08:46:27]

Committed patchset #2 manually as r19539 (presubmit successful).