Issue 125263002: Fix disassembler crash when mistaking integer values for objects.

Issue 125263002: Fix disassembler crash when mistaking integer values for objects. (Closed)

Created:
6 years, 11 months ago by srdjan

Modified:
6 years, 11 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, hausner

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix disassembler crash when mistaking integer values for objects. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=31576

Patch Set 4 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -2 lines)			Patch
M	runtime/vm/disassembler.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler.cc	View	1 2	1 chunk	+26 lines, -0 lines	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_x64.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/heap.h	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/heap.cc	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download
A	tests/language/disasssemble_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTMwC -Ivan https://codereview.chromium.org/125263002/diff/130001/runtime/vm/disassembler_ia32.cc File runtime/vm/disassembler_ia32.cc (right): https://codereview.chromium.org/125263002/diff/130001/runtime/vm/disassembler_ia32.cc#newcode477 runtime/vm/disassembler_ia32.cc:477: Isolate::Current()->heap()->OldContains(addr - kHeapObjectTag) && CanFindOldObject does OldContains ...

6 years, 11 months ago (2014-01-07 20:54:59 UTC) #2

srdjan

https://codereview.chromium.org/125263002/diff/130001/runtime/vm/disassembler_ia32.cc File runtime/vm/disassembler_ia32.cc (right): https://codereview.chromium.org/125263002/diff/130001/runtime/vm/disassembler_ia32.cc#newcode477 runtime/vm/disassembler_ia32.cc:477: Isolate::Current()->heap()->OldContains(addr - kHeapObjectTag) && On 2014/01/07 20:54:59, Ivan Posva ...

6 years, 11 months ago (2014-01-07 21:02:56 UTC) #3

srdjan

6 years, 11 months ago (2014-01-07 21:12:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r31576 (presubmit successful).

Expand Messages | Collapse Messages