Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 125253005: Formatter support for metadata. (Closed)

Created:
6 years, 11 months ago by pquitslund
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Formatter support for metadata. As per the spec: "Metadata can appear before a library, class, typedef, type parameter, constructor, factory, function, field, parameter, or variable declaration and before an import or export directive." R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31502

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -2 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 12 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 chunk +85 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 11 months ago (2014-01-06 19:07:18 UTC) #1
Brian Wilkerson
LGTM
6 years, 11 months ago (2014-01-06 19:10:09 UTC) #2
pquitslund
6 years, 11 months ago (2014-01-06 19:15:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31502 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698