Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1252443002: Add tests for problem with newline encoding in multiline strings. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, kasperl
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add tests for problem with newline encoding in multiline strings. R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/f49f00608f9f01bb5417aed0fc078e7c7bde3908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -12 lines) Patch
M .gitattributes View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/language/language_analyzer.status View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +7 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +8 lines, -0 lines 0 comments Download
A tests/language/multiline_newline_cr.dart View 1 chunk +1 line, -0 lines 0 comments Download
A + tests/language/multiline_newline_crlf.dart View 1 chunk +15 lines, -9 lines 0 comments Download
A + tests/language/multiline_newline_lf.dart View 1 chunk +9 lines, -3 lines 0 comments Download
A tests/language/multiline_newline_test.dart View 1 chunk +57 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-22 09:47:27 UTC) #2
karlklose
LGTM.
5 years, 5 months ago (2015-07-22 10:19:08 UTC) #3
Johnni Winther
5 years, 5 months ago (2015-07-22 11:10:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f49f00608f9f01bb5417aed0fc078e7c7bde3908 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698