Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 12518013: Ensure proper order of overload checks. (Closed)

Created:
7 years, 9 months ago by Anton Muhin
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Ensure proper order of overload checks. As dart:typeddata's class can implement both counterpart of ArrayBufferView and of ArrayBuffer, always favour treatment of an argument as an ArrayBufferView. R=ager@google.com,podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=19842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M sdk/lib/html/dartium/html_dartium.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tools/dom/scripts/htmldartgenerator.py View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anton Muhin
7 years, 9 months ago (2013-03-11 18:59:46 UTC) #1
Mads Ager (google)
LGTM
7 years, 9 months ago (2013-03-12 07:46:13 UTC) #2
Anton Muhin
7 years, 9 months ago (2013-03-12 09:04:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698