Issue 12518009: Remove virtual functions on class InliningContext.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12518009: Remove virtual functions on class InliningContext. (Closed)

Created:
7 years, 9 months ago by Kevin Millikin (Google)

Modified:
7 years, 9 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Remove virtual functions on class InliningContext. There is only one implementation of InliningContext, so there is no need for virtual dispatch. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=19917

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -44 lines)			Patch
M	runtime/vm/flow_graph_builder.h	View	3 chunks	+12 lines, -29 lines	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	3 chunks	+6 lines, -11 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Kevin Millikin (Google)

7 years, 9 months ago (2013-03-13 10:06:22 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19917 (presubmit successful).