Issue 12517013: Add SDK dependencies when pushing a package.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12517013: Add SDK dependencies when pushing a package. (Closed)

Created:
7 years, 9 months ago by dgrove

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add SDK dependencies when pushing a package. Committed: https://code.google.com/p/dart/source/detail?r=20131

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	tools/publish_pkg.py	View		2 chunks	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm - is that version just 0.4.2 or does it include the revision number (+0....)?

7 years, 9 months ago (2013-03-16 00:04:54 UTC) #2

dgrove

On 2013/03/16 00:04:54, Siggi Cherem (dart-lang) wrote: > lgtm - is that version just 0.4.2 ...

7 years, 9 months ago (2013-03-16 00:06:19 UTC) #4

dgrove

Committed patchset #1 manually as r20131 (presubmit successful).

7 years, 9 months ago (2013-03-16 00:06:47 UTC) #5

Siggi Cherem (dart-lang)

7 years, 9 months ago (2013-03-16 00:07:57 UTC) #6

Message was sent while issue was closed.

On 2013/03/16 00:06:19, dgrove wrote:
> On 2013/03/16 00:04:54, Siggi Cherem (dart-lang) wrote:
> > lgtm - is that version just 0.4.2 or does it include the revision number
> > (+0....)?
> 
> it includes the version (as +x) if the version isn't 0.
THanks,

Yeah I meant like +0.r12345 =)

Expand Messages | Collapse Messages