Issue 1251663002: Remove redundant context lookups from option-processing code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1251663002: Remove redundant context lookups from option-processing code. (Closed)

Created:
5 years, 5 months ago by Paul Berry

Modified:
5 years, 5 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, Cutch

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Remove redundant context lookups from option-processing code. This required exposing the ContextInfo class for testing, but I don't think that's a problem because ContextInfo objects can't be reached through the public API of ContextManager. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e30ebf79e2ea8e14b3fcd675acfd7cb8a9cfa4ae

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+151 lines, -148 lines)			Patch
	M	pkg/analysis_server/lib/src/context_manager.dart	View		25 chunks	+149 lines, -147 lines	0 comments	Download
	M	pkg/analysis_server/test/context_manager_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

5 years, 5 months ago (2015-07-21 22:06:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e30ebf79e2ea8e14b3fcd675acfd7cb8a9cfa4ae (presubmit successful).