Issue 12513010: Fixing Node.nodes.first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12513010: Fixing Node.nodes.first. (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fixing Node.nodes.first. Was throwing an incorrect exception because the JS type was being annotated as non-null. BUG=9070 Committed: https://code.google.com/p/dart/source/detail?r=19834

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -6 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	tests/html/node_test.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Node.darttemplate	View	2 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

blois

7 years, 9 months ago (2013-03-12 00:59:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19834 (presubmit successful).