Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1251073002: Test is actually not failing. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, herhut, Siggi Cherem (dart-lang)
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M tests/language/language_dart2js.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
The test is apparently not failing. Maybe it's just for my new emitter. I will ...
5 years, 5 months ago (2015-07-22 12:10:59 UTC) #2
floitsch
TBR.
5 years, 5 months ago (2015-07-22 12:11:05 UTC) #3
floitsch
Committed patchset #1 (id:1) manually as 2037ddc5649ce72b93335babc3e24c28aa92d7c1 (presubmit successful).
5 years, 5 months ago (2015-07-22 12:11:16 UTC) #4
karlklose
5 years, 5 months ago (2015-07-22 12:13:33 UTC) #5
Message was sent while issue was closed. 
LGTM.

Powered by Google App Engine
This is Rietveld 408576698