Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250923003: Fix decoration of ObjectPool references to stubs broken by their movement to VM isolate. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix decoration of ObjectPool references to stubs broken by their movement to VM isolate. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/59d113a26f33aacc57ec9f6669846842196c772b

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -8 lines) Patch
M runtime/vm/service.cc View 1 2 2 chunks +26 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-23 23:58:08 UTC) #2
Cutch
LGTM with a suggestion https://chromiumcodereview.appspot.com/1250923003/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://chromiumcodereview.appspot.com/1250923003/diff/20001/runtime/vm/service.cc#newcode2606 runtime/vm/service.cc:2606: object = Dart::vm_isolate()->heap()->FindObject(&visitor); Maybe refactor ...
5 years, 5 months ago (2015-07-23 23:59:25 UTC) #3
rmacnak
https://chromiumcodereview.appspot.com/1250923003/diff/20001/runtime/vm/service.cc File runtime/vm/service.cc (right): https://chromiumcodereview.appspot.com/1250923003/diff/20001/runtime/vm/service.cc#newcode2606 runtime/vm/service.cc:2606: object = Dart::vm_isolate()->heap()->FindObject(&visitor); On 2015/07/23 23:59:25, Cutch wrote: > ...
5 years, 5 months ago (2015-07-24 00:17:45 UTC) #4
rmacnak
5 years, 5 months ago (2015-07-24 00:17:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
59d113a26f33aacc57ec9f6669846842196c772b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698