Logging page

Logging page

- Per isolate logging page.
- Drop down to control log level threshold.
- Console area where messages are displayed.
- UI test.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/d3154f4247220aae21551b0b9c406dd965722045

[Cutch, 2015-07-21 23:17:28]

johnmccutchan@google.com changed reviewers:
+ rmacnak@google.com

[rmacnak, 2015-07-22 00:29:27]

LGTM w/c

For later we should also consider whether logging events should also appear in
the debugger's console so one can correlate log events with pause/resume events.

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/logging.dart (right):

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/logging.dart:141: if (lastElement != null)
{
Should only scroll if already positioned at the end so one can scroll up without
having to fight the new output.

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/logging.dart:148: assert(event.kind ==
VM.kLoggingStream);
Isolate.kLoggingStream

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/logging.html (right):

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/logging.html:64: <select
id="severityLevelSelector" value="{{ severityLevel }}"></select>
This results in a very-vertically-stretched box left of the messages.
It would be better the put the select above the messages with a label.

<div>Log filter: <select ...></select></div>
<div id=log></div>

[Cutch, 2015-07-22 21:33:19]

Committed patchset #3 (id:40001) manually as
d3154f4247220aae21551b0b9c406dd965722045 (presubmit successful).

[Cutch, 2015-07-22 21:33:32]

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/logging.dart (right):

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/logging.dart:141: if (lastElement != null)
{
On 2015/07/22 00:29:26, rmacnak wrote:
> Should only scroll if already positioned at the end so one can scroll up
without
> having to fight the new output.

Done.

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/logging.dart:148: assert(event.kind ==
VM.kLoggingStream);
On 2015/07/22 00:29:26, rmacnak wrote:
> Isolate.kLoggingStream

Done.

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/logging.html (right):

https://codereview.chromium.org/1250853006/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/logging.html:64: <select
id="severityLevelSelector" value="{{ severityLevel }}"></select>
On 2015/07/22 00:29:26, rmacnak wrote:
> This results in a very-vertically-stretched box left of the messages.
> It would be better the put the select above the messages with a label.
> 
> <div>Log filter: <select ...></select></div>
> <div id=log></div>

Done.