Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 12507012: - Use dart:typeddata in the tests instead of dart:scalarlist (Closed)

Created:
7 years, 9 months ago by siva
Modified:
7 years, 9 months ago
Reviewers:
hausner
CC:
reviews_dartlang.org
Visibility:
Public.

Description

- Use dart:typeddata in the tests instead of dart:scalarlist - delete byte_array_test.dart as a dart:typeddata version of this test is present in typed_data_test.dart Committed: https://code.google.com/p/dart/source/detail?r=20600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -297 lines) Patch
D tests/standalone/byte_array_test.dart View 1 chunk +0 lines, -289 lines 0 comments Download
M tests/standalone/byte_array_view_optimized_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/http_client_request_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_compression_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_parser_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/http_server_response_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/web_socket_protocol_processor_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 9 months ago (2013-03-28 00:19:03 UTC) #1
hausner
lgtm
7 years, 9 months ago (2013-03-28 00:32:51 UTC) #2
siva
7 years, 9 months ago (2013-03-28 00:35:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698