Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250633002: Add operators test to source_mapping_test. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 8

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -231 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 12 chunks +41 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 20 chunks +40 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 4 chunks +12 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 13 chunks +31 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 2 1 chunk +18 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 4 chunks +8 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 5 chunks +23 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 3 chunks +14 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 6 chunks +29 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/colors.dart View 4 chunks +36 lines, -4 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/invokes_test_file.dart View 1 chunk +0 lines, -1 line 0 comments Download
A tests/compiler/dart2js/sourcemaps/operators_test_file.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/source_mapping_test.dart View 1 2 1 chunk +70 lines, -95 lines 0 comments Download
A tests/compiler/dart2js/sourcemaps/source_mapping_test_viewer.dart View 1 2 1 chunk +166 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_helper.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_html_helper.dart View 5 chunks +24 lines, -12 lines 0 comments Download
M tests/compiler/dart2js/sourcemaps/sourcemap_html_templates.dart View 1 chunk +106 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-21 14:17:34 UTC) #2
karlklose
LGTM. https://codereview.chromium.org/1250633002/diff/20001/pkg/compiler/lib/src/io/position_information.dart File pkg/compiler/lib/src/io/position_information.dart (right): https://codereview.chromium.org/1250633002/diff/20001/pkg/compiler/lib/src/io/position_information.dart#newcode185 pkg/compiler/lib/src/io/position_information.dart:185: // example. The latter is needed if when ...
5 years, 5 months ago (2015-07-22 09:06:48 UTC) #3
Johnni Winther
https://codereview.chromium.org/1250633002/diff/20001/pkg/compiler/lib/src/io/position_information.dart File pkg/compiler/lib/src/io/position_information.dart (right): https://codereview.chromium.org/1250633002/diff/20001/pkg/compiler/lib/src/io/position_information.dart#newcode185 pkg/compiler/lib/src/io/position_information.dart:185: // example. The latter is needed if when both ...
5 years, 5 months ago (2015-07-22 10:50:05 UTC) #4
Johnni Winther
5 years, 5 months ago (2015-07-22 11:04:11 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
6d38ebd06e80c5604ea4d18c9b88cb2b7eb3b94b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698