Issue 12506004: Added window.requestAnimationFrame.

Issue 12506004: Added window.requestAnimationFrame. (Closed)

Created:
7 years, 9 months ago by gram

Modified:
7 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Added window.requestAnimationFrame. Committed: https://code.google.com/p/dart/source/detail?r=19665

Patch Set 2 : #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+54 lines, -7 lines)			Patch
M	runtime/embedders/openglui/common/gl.dart	View	1	2 chunks	+42 lines, -0 lines	0 comments	Download
M	runtime/embedders/openglui/common/vm_glue.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	samples/openglui/android/android.gyp	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	samples/openglui/src/openglui_canvas_tests.dart	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
M	samples/openglui/src/openglui_raytrace.dart	View	1	2 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

gram

NB I changed update to update_ for now. Tomorrow I'll look at naming this _update ...

7 years, 9 months ago (2013-03-06 01:13:33 UTC) #1

vsm

lgtm https://codereview.chromium.org/12506004/diff/1/runtime/embedders/openglui/common/gl.dart File runtime/embedders/openglui/common/gl.dart (right): https://codereview.chromium.org/12506004/diff/1/runtime/embedders/openglui/common/gl.dart#newcode22 runtime/embedders/openglui/common/gl.dart:22: Map<int, Function> _callbacks; Might as well s/Function/RequestAnimationFrameCallback/ since ...

7 years, 9 months ago (2013-03-07 23:53:04 UTC) #2

gram

https://codereview.chromium.org/12506004/diff/1/runtime/embedders/openglui/common/gl.dart File runtime/embedders/openglui/common/gl.dart (right): https://codereview.chromium.org/12506004/diff/1/runtime/embedders/openglui/common/gl.dart#newcode22 runtime/embedders/openglui/common/gl.dart:22: Map<int, Function> _callbacks; On 2013/03/07 23:53:04, vsm wrote: > ...

7 years, 9 months ago (2013-03-08 00:26:42 UTC) #3

gram

7 years, 9 months ago (2013-03-08 00:27:18 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19665 (presubmit successful).

Expand Messages | Collapse Messages