Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 1250373007: Fix missing generic type parameters on streams. (Closed)

Created:
5 years, 4 months ago by Lasse Reichstein Nielsen
Modified:
5 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix missing generic type parameters on streams. Add test. BUG=23859 R=sgjesse@google.com Committed: https://github.com/dart-lang/sdk/commit/ac33dfe1946f2a36e3ec7863d8c1da113f3118cf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -8 lines) Patch
M sdk/lib/async/stream.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/async/stream_controller.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/async/stream_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/async/stream_type_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-03 09:59:56 UTC) #2
Søren Gjesse
lgtm
5 years, 4 months ago (2015-08-03 10:51:11 UTC) #3
Lasse Reichstein Nielsen
5 years, 4 months ago (2015-08-03 12:22:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ac33dfe1946f2a36e3ec7863d8c1da113f3118cf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698