Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1250343002: performance measurement improvements and README update (Closed)

Created:
5 years, 5 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

performance measurement improvements and README update BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/ddf17fa5750dec34e45a67be8dc7a45a39092e85

Patch Set 1 #

Patch Set 2 : doc tweak #

Total comments: 2

Patch Set 3 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -52 lines) Patch
M pkg/analysis_server/benchmark/integration/README.md View 1 2 chunks +26 lines, -1 line 0 comments Download
M pkg/analysis_server/benchmark/integration/local_runner.dart View 3 chunks +17 lines, -13 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/main.dart View 1 2 3 chunks +42 lines, -37 lines 0 comments Download
M pkg/analysis_server/benchmark/integration/operation.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
danrubel
5 years, 5 months ago (2015-07-24 00:56:42 UTC) #2
Brian Wilkerson
LGTM https://codereview.chromium.org/1250343002/diff/20001/pkg/analysis_server/benchmark/integration/main.dart File pkg/analysis_server/benchmark/integration/main.dart (right): https://codereview.chromium.org/1250343002/diff/20001/pkg/analysis_server/benchmark/integration/main.dart#newcode2 pkg/analysis_server/benchmark/integration/main.dart:2: ???
5 years, 5 months ago (2015-07-24 13:18:21 UTC) #3
danrubel
Committed patchset #3 (id:40001) manually as ddf17fa5750dec34e45a67be8dc7a45a39092e85 (presubmit successful).
5 years, 5 months ago (2015-07-24 14:13:18 UTC) #4
danrubel
5 years, 4 months ago (2015-08-03 13:26:10 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/1250343002/diff/20001/pkg/analysis_server/ben...
File pkg/analysis_server/benchmark/integration/main.dart (right):

https://codereview.chromium.org/1250343002/diff/20001/pkg/analysis_server/ben...
pkg/analysis_server/benchmark/integration/main.dart:2: 
On 2015/07/24 13:18:21, Brian Wilkerson wrote:
> ???

Not sure how/when this blank line got added. Removed.

Powered by Google App Engine
This is Rietveld 408576698