Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issue 125003002: Fix Directory path in VirtualDirectory, so it always ends with a platform-specific seperator. That'… (Closed)

Created:
6 years, 11 months ago by Anders Johnsen
Modified:
6 years, 11 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, sethladd
Visibility:
Public.

Description

Fix Directory path in VirtualDirectory, so it always ends with a platform-specific seperator. That'll make sure Uri.resolve always works. BUG=http://code.google.com/p/dart/issues/detail?id=15764 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31469

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -2 lines) Patch
M pkg/http_server/lib/src/virtual_directory.dart View 2 chunks +6 lines, -2 lines 0 comments Download
M pkg/http_server/test/virtual_directory_test.dart View 1 chunk +34 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 11 months ago (2014-01-06 10:38:34 UTC) #1
Søren Gjesse
lgtm
6 years, 11 months ago (2014-01-06 10:43:43 UTC) #2
Anders Johnsen
6 years, 11 months ago (2014-01-06 10:44:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31469 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698