Issue 1250023002: dart2js: Add an empty "MANGLED_NAMES" embedded global to the startup-emitter.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1250023002: dart2js: Add an empty "MANGLED_NAMES" embedded global to the startup-emitter. (Closed)

Created:
5 years, 5 months ago by floitsch

Modified:
5 years, 4 months ago

Reviewers:
Siggi Cherem (dart-lang), herhut

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

dart2js: Add an empty "MANGLED_NAMES" embedded global to the startup-emitter. There will be another update on this embedded global. In fact it is needed for const symbols. For simplicity I would prefer committing this CL first (to avoid too much merging/rebasing). R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/3880150e3acea7764e2b76478d66d3167f1dbeb9

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

floitsch

5 years, 4 months ago (2015-08-03 15:47:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3880150e3acea7764e2b76478d66d3167f1dbeb9 (presubmit successful).