Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 12500005: Add a failing test for handling broken symlinks. (Closed)

Created:
7 years, 9 months ago by Bob Nystrom
Modified:
7 years, 9 months ago
Reviewers:
nweiz, Andrei Mouravski
CC:
reviews_dartlang.org, nweiz
Visibility:
Public.

Description

Add a failing test for handling broken symlinks. BUG=8343 Committed: https://code.google.com/p/dart/source/detail?r=19580

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -18 lines) Patch
A + utils/tests/pub/install/broken_symlink_test.dart View 1 chunk +19 lines, -18 lines 3 comments Download
M utils/tests/pub/pub.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Bob Nystrom
I started looking into https://code.google.com/p/dart/issues/detail?id=8343, but it seems I won't be able to fix it ...
7 years, 9 months ago (2013-03-06 00:38:18 UTC) #1
Andrei Mouravski
lgtm https://codereview.chromium.org/12500005/diff/1/utils/tests/pub/install/broken_symlink_test.dart File utils/tests/pub/install/broken_symlink_test.dart (left): https://codereview.chromium.org/12500005/diff/1/utils/tests/pub/install/broken_symlink_test.dart#oldcode23 utils/tests/pub/install/broken_symlink_test.dart:23: libDir('foo') Could you make all "s into 's?
7 years, 9 months ago (2013-03-06 01:25:46 UTC) #2
nweiz
Do we want one of these for broken links within "packages" as well? https://codereview.chromium.org/12500005/diff/1/utils/tests/pub/install/broken_symlink_test.dart File ...
7 years, 9 months ago (2013-03-06 20:13:52 UTC) #3
Bob Nystrom
https://codereview.chromium.org/12500005/diff/1/utils/tests/pub/install/broken_symlink_test.dart File utils/tests/pub/install/broken_symlink_test.dart (left): https://codereview.chromium.org/12500005/diff/1/utils/tests/pub/install/broken_symlink_test.dart#oldcode23 utils/tests/pub/install/broken_symlink_test.dart:23: libDir('foo') On 2013/03/06 01:25:46, Andrei Mouravski wrote: > Could ...
7 years, 9 months ago (2013-03-06 20:55:55 UTC) #4
Bob Nystrom
7 years, 9 months ago (2013-03-06 20:55:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r19580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698