Rename assembler field/getter/setter allow_constant_pool to constant_pool_allowed

Rename assembler field/getter/setter allow_constant_pool to constant_pool_allowed

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/3b2a4cb33c3d2c3d39cff7e9846cbfbf538d01c9

[regis, 2015-07-22 21:15:39]

regis@google.com changed reviewers:
+ zra@google.com

[regis, 2015-07-22 21:15:39]

This is purely mechanical (global replace).

[zra, 2015-07-22 21:20:40]

lgtm

[regis, 2015-07-22 21:51:53]

Committed patchset #1 (id:1) manually as
3b2a4cb33c3d2c3d39cff7e9846cbfbf538d01c9 (presubmit successful).

[Florian Schneider, 2015-07-23 12:19:06]

On 2015/07/22 21:15:39, regis wrote:
> This is purely mechanical (global replace).

I don't see the point of this renaming - this seems purely a matter of taste.

[regis, 2015-07-23 16:08:53]

On 2015/07/23 12:19:06, Florian Schneider wrote:
> On 2015/07/22 21:15:39, regis wrote:
> > This is purely mechanical (global replace).
> 
> I don't see the point of this renaming - this seems purely a matter of taste.

It's more a matter of grammar than taste. To me, "allow_constant_pool()" means
"please, from now on, allow the use of the constant pool", rather than "is the
usage of the constant pool allowed?".

In a future cl, the usage of the constant pool will rely on this assembler field
rather than on an explicitly passed argument.