Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 12496011: Added support for redirecting factories in dart api. (Closed)

Created:
7 years, 9 months ago by aam-me
Modified:
7 years, 9 months ago
Reviewers:
regis, dgrove
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Added support for redirecting factories in dart api. BUG=dartbug.com/6958 Committed: https://code.google.com/p/dart/source/detail?r=20366

Patch Set 1 #

Patch Set 2 : Restored comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -97 lines) Patch
M runtime/tests/vm/vm.status View 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 1 chunk +5 lines, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 8 chunks +22 lines, -91 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
aam-me
Hi, I stumbled on this bug and thought to give it a go. Please take ...
7 years, 9 months ago (2013-03-18 05:20:43 UTC) #1
regis
LGTM Sorry for the delay. I'm just back from vacation. -- Regis
7 years, 9 months ago (2013-03-21 17:06:15 UTC) #2
aam-me
7 years, 9 months ago (2013-03-22 03:31:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r20366 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698