Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 12494015: Automatically determine the gcc compiler to use based on XCode version (Closed)

Created:
7 years, 9 months ago by kustermann
Modified:
7 years, 9 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Automatically determine the gcc compiler to use based on XCode version Committed: https://code.google.com/p/dart/source/detail?r=20190

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -9 lines) Patch
M tools/gyp/configurations_xcode.gypi View 1 chunk +1 line, -9 lines 0 comments Download
A tools/gyp/find_mac_gcc_version.py View 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kustermann
7 years, 9 months ago (2013-03-18 14:08:18 UTC) #1
ricow1
LGTM
7 years, 9 months ago (2013-03-18 14:17:45 UTC) #2
Ivan Posva
LGTM -ip
7 years, 9 months ago (2013-03-19 03:37:11 UTC) #3
kustermann
7 years, 9 months ago (2013-03-19 08:28:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r20190 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698