Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 12493003: Exposing Point & Rect types (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Exposing Point & Rect types This exposes ClientRects as Rects and exposes UIEvent.clientX/Y properties as Points. This also deprecates the UIEvent.clientX/Y properties. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19659

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Sync to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+761 lines, -417 lines) Patch
M samples/dartcombat/views.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/solar3d/web/solar.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/spirodraw/web/colorpicker.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Geometry.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Scrollbar.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/TouchHandler.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/TouchUtil.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M samples/swipe/web/swipe.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 20 chunks +284 lines, -144 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 20 chunks +274 lines, -125 lines 0 comments Download
M tests/html/client_rect_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/event_test.dart View 2 chunks +10 lines, -10 lines 0 comments Download
M tests/html/point_test.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/html/rect_test.dart View 1 1 chunk +0 lines, -8 lines 0 comments Download
M tests/html/wheelevent_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/scripts/generator.py View 3 chunks +6 lines, -2 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 2 chunks +18 lines, -0 lines 0 comments Download
M tools/dom/src/Rectangle.dart View 1 1 chunk +1 line, -8 lines 0 comments Download
M tools/dom/src/dart2js_KeyEvent.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/dom/src/dartium_KeyEvent.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M tools/dom/templates/html/dart2js/impl_MouseEvent.darttemplate View 2 chunks +39 lines, -27 lines 0 comments Download
M tools/dom/templates/html/dartium/impl_MouseEvent.darttemplate View 1 chunk +41 lines, -0 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_ClientRect.darttemplate View 1 2 chunks +5 lines, -46 lines 0 comments Download
A tools/dom/templates/html/impl/impl_Touch.darttemplate View 1 chunk +22 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_UIEvent.darttemplate View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
blois
7 years, 9 months ago (2013-03-06 01:10:18 UTC) #1
Jennifer Messerly
lgtm https://codereview.chromium.org/12493003/diff/6010/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12493003/diff/6010/tools/dom/scripts/generator.py#newcode1383 tools/dom/scripts/generator.py:1383: item_type='ClientRect', dart_type='List<Rect>', suppress_interface=True), not sure if our python ...
7 years, 9 months ago (2013-03-06 01:27:21 UTC) #2
blois
https://codereview.chromium.org/12493003/diff/6010/tools/dom/scripts/generator.py File tools/dom/scripts/generator.py (right): https://codereview.chromium.org/12493003/diff/6010/tools/dom/scripts/generator.py#newcode1383 tools/dom/scripts/generator.py:1383: item_type='ClientRect', dart_type='List<Rect>', suppress_interface=True), On 2013/03/06 01:27:21, John Messerly wrote: ...
7 years, 9 months ago (2013-03-06 01:30:04 UTC) #3
blois
7 years, 9 months ago (2013-03-07 22:17:20 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r19659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698