Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1249023003: Clarify nomenclature of "ancestor" and "root" in context manager. (Closed)

Created:
5 years, 5 months ago by Paul Berry
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Clarify nomenclature of "ancestor" and "root" in context manager. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/b3d245d6085fb823fc8a231d8076d5b3ca06c82a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 6 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 5 months ago (2015-07-22 17:51:30 UTC) #2
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-22 18:06:14 UTC) #3
Paul Berry
5 years, 5 months ago (2015-07-22 19:53:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b3d245d6085fb823fc8a231d8076d5b3ca06c82a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698