Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1249023002: dart2js: support isolates in the startup-emitter. (Closed)

Created:
5 years, 5 months ago by floitsch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, herhut
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix indentation. #

Total comments: 2

Patch Set 3 : Fix typo. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -33 lines) Patch
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 2 10 chunks +119 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 4 chunks +7 lines, -5 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 5 chunks +20 lines, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart View 1 2 5 chunks +39 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
5 years, 5 months ago (2015-07-22 15:21:32 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/1249023002/diff/20001/sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right): https://codereview.chromium.org/1249023002/diff/20001/sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart#newcode422 sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:422: /// This builtin is used hen a static ...
5 years, 5 months ago (2015-07-23 17:59:19 UTC) #3
floitsch
https://codereview.chromium.org/1249023002/diff/20001/sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart File sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart (right): https://codereview.chromium.org/1249023002/diff/20001/sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart#newcode422 sdk/lib/_internal/js_runtime/lib/shared/embedded_names.dart:422: /// This builtin is used hen a static closure ...
5 years, 4 months ago (2015-07-29 18:02:00 UTC) #4
floitsch
5 years, 4 months ago (2015-08-03 15:48:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
8d6063d8068288bf4d179afcbde9ecaf0fe3dfc2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698