Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1248833003: Move shared class to it's own library. (Closed)

Created:
5 years, 5 months ago by sigurdm
Modified:
5 years, 5 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Move shared class to it's own library. The multi-test framework did not like my circular imports. BUG= Committed: https://github.com/dart-lang/sdk/commit/0a12c3751637404b6548b1b9e807f3c9c913efd9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M tests/language/deferred_type_dependency_lib1.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/deferred_type_dependency_lib2.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/language/deferred_type_dependency_lib3.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/deferred_type_dependency_test.dart View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
sigurdm
TBR
5 years, 5 months ago (2015-07-22 16:56:16 UTC) #2
sigurdm
5 years, 5 months ago (2015-07-22 16:59:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0a12c3751637404b6548b1b9e807f3c9c913efd9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698