Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 124863004: Formatter fixes (symbols, natives, function type aliases, oh my). (Closed)

Created:
6 years, 11 months ago by pquitslund
Modified:
6 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Formatter fixes (symbols, natives, function type aliases, oh my). Last stragglers that make a run over the SDK go green (modulo patch files that is). R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=31513

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -3 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 1 4 chunks +16 lines, -2 lines 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 3 chunks +37 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 11 months ago (2014-01-06 21:35:01 UTC) #1
Brian Wilkerson
LGTM
6 years, 11 months ago (2014-01-06 21:40:25 UTC) #2
pquitslund
6 years, 11 months ago (2014-01-06 22:22:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r31513 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698