Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 1248483003: Write binstubs using the system encoding. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Write binstubs using the system encoding. Closes #1304 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/bc776a2e1364b5004d8e2601b2bafb8f93c6a396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M lib/src/global_packages.dart View 2 chunks +4 lines, -1 line 0 comments Download
M lib/src/io.dart View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 5 months ago (2015-07-20 21:40:20 UTC) #1
Bob Nystrom
lgtm
5 years, 5 months ago (2015-07-20 21:43:59 UTC) #2
nweiz
5 years, 5 months ago (2015-07-20 21:48:23 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc776a2e1364b5004d8e2601b2bafb8f93c6a396 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698