Issue 12481016: And another... :(

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12481016: And another... :( (Closed)

Created:
7 years, 9 months ago by Anders Johnsen

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	A	runtime/bin/filter_patch.dart	View		1 chunk	+33 lines, -0 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/implementation/lib/io_patch.dart	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Søren Gjesse

lgtm, but Then you need a dummy implementation in sdk/lib/_internal/compiler/implementation/lib/io.dart.

7 years, 9 months ago (2013-03-06 11:49:53 UTC) #2

Anders Johnsen

7 years, 9 months ago (2013-03-06 11:53:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r19553 (presubmit successful).