Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 1248073003: Add a --pause-after-load flag for debugging. (Closed)

Created:
5 years, 5 months ago by nweiz
Modified:
5 years, 5 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add a --pause-after-load flag for debugging. Currently this only support windowed browsers and the runner can only be unpaused from the command line. See #294 R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/653ef174e456b4e49b1c09de2905bc078b94ad47

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+607 lines, -98 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/src/backend/live_test_controller.dart View 1 chunk +9 lines, -1 line 2 comments Download
M lib/src/executable.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M lib/src/runner.dart View 7 chunks +118 lines, -42 lines 0 comments Download
M lib/src/runner/configuration.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M lib/src/runner/engine.dart View 2 chunks +7 lines, -1 line 0 comments Download
A lib/src/runner/reporter.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M lib/src/runner/reporter/compact.dart View 8 chunks +64 lines, -18 lines 0 comments Download
M lib/src/runner/reporter/expanded.dart View 9 chunks +57 lines, -11 lines 0 comments Download
D lib/src/util/delegating_sink.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M lib/src/util/io.dart View 3 chunks +20 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 2 chunks +45 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +3 lines, -1 line 0 comments Download
A test/runner/pause_after_load_test.dart View 1 chunk +237 lines, -0 lines 0 comments Download
M test/runner/runner_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 5 months ago (2015-07-23 20:38:17 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1248073003/diff/1/lib/src/backend/live_test_controller.dart File lib/src/backend/live_test_controller.dart (right): https://codereview.chromium.org/1248073003/diff/1/lib/src/backend/live_test_controller.dart#newcode155 lib/src/backend/live_test_controller.dart:155: if (_onPrintController.hasListener) { what's a case where the ...
5 years, 5 months ago (2015-07-23 20:47:03 UTC) #2
nweiz
https://codereview.chromium.org/1248073003/diff/1/lib/src/backend/live_test_controller.dart File lib/src/backend/live_test_controller.dart (right): https://codereview.chromium.org/1248073003/diff/1/lib/src/backend/live_test_controller.dart#newcode155 lib/src/backend/live_test_controller.dart:155: if (_onPrintController.hasListener) { On 2015/07/23 20:47:03, kevmoo wrote: > ...
5 years, 5 months ago (2015-07-23 21:23:00 UTC) #3
nweiz
5 years, 5 months ago (2015-07-23 21:24:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
653ef174e456b4e49b1c09de2905bc078b94ad47 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698