Parameterize the import directories, fix test to behave correctly on an error

Parameterize the import directories, fix test to behave correctly on an error

Committed: https://code.google.com/p/dart/source/detail?r=20241

[Alan Knight, 2013-03-19 20:27:51]

Parameterize where the generated code finds imports, both for its dependencies
(which shouldn't often need to be changed, but might) and for where the
generated code can be found, which is quite likely to vary.

There was also a problem with not returning the last Future so the test
framework would run through and think it had completed successfully even when
there was an error.

[Emily Fortuna, 2013-03-19 20:31:37]

lgtm, with the fix to message_extraction_test first.

https://codereview.chromium.org/12478010/diff/1/pkg/intl/test/message_extract...
File pkg/intl/test/message_extraction/message_extraction_test.dart (left):

https://codereview.chromium.org/12478010/diff/1/pkg/intl/test/message_extract...
pkg/intl/test/message_extraction/message_extraction_test.dart:58:
extractMessages(null).then((result) {
if you just add a return statement at this line:
return extractMessage(null)..... 

you should get what you're looking for.

[Alan Knight, 2013-03-19 20:53:30]

Committed patchset #1 manually as r20241 (presubmit successful).

[Alan Knight, 2013-03-19 20:53:46]

https://codereview.chromium.org/12478010/diff/1/pkg/intl/test/message_extract...
File pkg/intl/test/message_extraction/message_extraction_test.dart (left):

https://codereview.chromium.org/12478010/diff/1/pkg/intl/test/message_extract...
pkg/intl/test/message_extraction/message_extraction_test.dart:58:
extractMessages(null).then((result) {
On 2013/03/19 20:31:37, Emily Fortuna wrote:
> if you just add a return statement at this line:
> return extractMessage(null)..... 
> 
> you should get what you're looking for.

Done.