Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1247773002: Add access the Message in CompilerDiagnostics.report. (Closed)

Created:
5 years, 5 months ago by Johnni Winther
Modified:
5 years, 5 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add access the Message in CompilerDiagnostics.report. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/4439c480b2032514cead97a4da9690c1326bdb68

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -151 lines) Patch
M pkg/compiler/lib/compiler_new.dart View 1 1 chunk +6 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/apiimpl.dart View 3 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/old_to_new_api.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/analyze_helper.dart View 4 chunks +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/bad_output_io_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/duplicate_library_test.dart View 7 chunks +36 lines, -31 lines 0 comments Download
M tests/compiler/dart2js/import_mirrors_test.dart View 2 chunks +21 lines, -19 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 4 chunks +55 lines, -13 lines 0 comments Download
M tests/compiler/dart2js/missing_file_test.dart View 1 chunk +14 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/package_root_test.dart View 2 chunks +48 lines, -48 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 5 months ago (2015-07-21 11:16:15 UTC) #2
karlklose
LGTM. The only concern I have is that we lose information about the things that ...
5 years, 5 months ago (2015-07-21 11:25:31 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 4439c480b2032514cead97a4da9690c1326bdb68 (presubmit successful).
5 years, 5 months ago (2015-07-21 12:36:54 UTC) #4
Johnni Winther
5 years, 5 months ago (2015-07-21 13:51:58 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1247773002/diff/1/pkg/compiler/lib/compiler_n...
File pkg/compiler/lib/compiler_new.dart (right):

https://codereview.chromium.org/1247773002/diff/1/pkg/compiler/lib/compiler_n...
pkg/compiler/lib/compiler_new.dart:71: /// Experimental: [code] is gives access
to an id for the messages. Currently
On 2015/07/21 11:25:31, karlklose wrote:
> '[code] gives' (remove 'is').

Done.

Powered by Google App Engine
This is Rietveld 408576698