Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 1247733005: Fix getField optimization when the selector is an operator. (Closed)

Created:
5 years, 5 months ago by rmacnak
Modified:
5 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix getField optimization when the selector is an operator. BUG=http://dartbug.com/23880 R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/bc90a5e1f043e3c47b725721a6d0670cf7e91ec4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -5 lines) Patch
M runtime/lib/mirrors_impl.dart View 1 chunk +10 lines, -5 lines 0 comments Download
M tests/lib/mirrors/hot_get_field_test.dart View 2 chunks +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 5 months ago (2015-07-22 17:36:58 UTC) #2
siva
lgtm
5 years, 5 months ago (2015-07-22 18:04:06 UTC) #3
rmacnak
5 years, 5 months ago (2015-07-22 20:39:12 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc90a5e1f043e3c47b725721a6d0670cf7e91ec4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698