Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 12475004: Add dart analyzer test suite 'analyze_library' that fails if we (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Add dart analyzer test suite 'analyze_library' that fails if we introduce static type warnings in certain dart libraries. I wanted this for dart:io and might as well add it for the other libraries that have no warnings when analyzed. This required a bit of test script reworking. dartc used a leading hash in a file to determine if it was a test. That is now broken and has been removed. This also allowed me to override the readOptionsFromFile method in test suites so that certain analyzer test suites can require all tests to be static clean. R=ricow@google.com,kustermann@google.com,sgjesse@google.com,danrubel@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19597

Patch Set 1 #

Total comments: 2

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -41 lines) Patch
M samples/tests/dartc/test_config.dart View 1 chunk +1 line, -6 lines 0 comments Download
M sdk/lib/crypto/crypto_utils.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M sdk/lib/json/json_base.dart View 3 chunks +17 lines, -15 lines 0 comments Download
M sdk/lib/mirrors/mirrors_impl.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A + tests/lib/analyzer/analyze_library.status View 1 chunk +0 lines, -4 lines 0 comments Download
A tests/lib/analyzer/test_config.dart View 1 1 chunk +31 lines, -0 lines 0 comments Download
M tools/test.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_runner.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/test_suite.dart View 9 chunks +22 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Mads Ager (google)
7 years, 9 months ago (2013-03-06 13:52:17 UTC) #1
Søren Gjesse
lgtm
7 years, 9 months ago (2013-03-06 14:19:56 UTC) #2
ricow1
LGTM https://codereview.chromium.org/12475004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/12475004/diff/1/tools/testing/dart/test_suite.dart#newcode1542 tools/testing/dart/test_suite.dart:1542: {bool this.allStaticClean: false}) we don't have to have ...
7 years, 9 months ago (2013-03-06 14:23:25 UTC) #3
Mads Ager (google)
https://codereview.chromium.org/12475004/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/12475004/diff/1/tools/testing/dart/test_suite.dart#newcode1542 tools/testing/dart/test_suite.dart:1542: {bool this.allStaticClean: false}) On 2013/03/06 14:23:25, ricow1 wrote: > ...
7 years, 9 months ago (2013-03-06 14:26:41 UTC) #4
kustermann
lgtm
7 years, 9 months ago (2013-03-06 14:45:21 UTC) #5
danrubel
lgtm
7 years, 9 months ago (2013-03-06 17:07:15 UTC) #6
Mads Ager (google)
7 years, 9 months ago (2013-03-07 07:25:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r19597 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698